From: Florian Müllner Date: Mon, 12 Dec 2022 17:28:04 +0000 (+0100) Subject: Revert "status/volume: Clear device menus when unsetting stream" X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~405^2^2~152 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=3de828cc608a0e48843c1d95c2e99d79a80505f0;p=gnome-shell.git Revert "status/volume: Clear device menus when unsetting stream" Device additions/removals are tracked by GvcMixerControl, which doesn't change when unsetting the stream. So clearing the menu manually was a workaround, not a fix. It's also worth noting that I failed to reproduce the original issue again, so it's possible that we were working around a pipewire bug that has since been fixed. This reverts commit 1b62b7ea0a8aff38ef8c6873cb8b7651abe24044. Part-of: --- diff --git a/js/ui/status/volume.js b/js/ui/status/volume.js index 57e179974..bd49cc3ae 100644 --- a/js/ui/status/volume.js +++ b/js/ui/status/volume.js @@ -83,8 +83,6 @@ const StreamSlider = GObject.registerClass({ this._connectStream(this._stream); this._updateVolume(); } else { - this._deviceSection.removeAll(); - this._deviceItems.clear(); this.emit('stream-updated'); }